Skip to content

Add hydropowerlib to list of projects#91

Open
Ludee wants to merge 1 commit into
masterfrom
feature/add-hydropower-lib
Open

Add hydropowerlib to list of projects#91
Ludee wants to merge 1 commit into
masterfrom
feature/add-hydropower-lib

Conversation

@Ludee

@Ludee Ludee commented Feb 23, 2021

Copy link
Copy Markdown

I would count the hydropowerlib as part of oemof since it is an extension of the feedinlib.

The hydropowerlib is designed to calculate feedin time series of run-of-the-river hydropower plants. The hydropowerlib is an out-take from the feedinlib (hydropower, windpower and pv) to build up a community concentrating on hydropower models.
https://github.com/hydro-python/hydropowerlib

There has not been a stable release yet.

@Ludee Ludee self-assigned this Feb 23, 2021
@codecov

codecov Bot commented Feb 23, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #91 (fc8adf1) into master (5900cda) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #91   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines            8         8           
=========================================
  Hits             8         8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5900cda...fc8adf1. Read the comment docs.

@simnh

simnh commented Feb 23, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Cool idea, but what do you mean be Add to projects. As far as there are others that are the core developers? why not leave it as hydro-python? (Do you plan to re-write the code for adhering to developing guidelines?) sorry- saw that they already use our rules...

Still, do you want to move the repository? Did you talk to Jonas?

@Ludee

Ludee commented Feb 23, 2021 •
edited
Loading

Copy link
Copy Markdown
Author

... what do you mean be Add to projects.

I added it to the list of "Projects in an early state" in the README.rst
For me this looks like an inventory of existing modules and packages of oemof.
While it is in an external repo, it is like the windowerlib.

@p-snft

p-snft commented Feb 24, 2021

Copy link
Copy Markdown
Member

I think as an oemof project, it should also be located at https://github.com/oemof/hydropowerlib.

@p-snft p-snft mentioned this pull request Feb 24, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Ludee Ludee

Labels

enhancement feedback wanted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ludee @simnh @p-snft