remove the x/net context in favour of the stdlib context#1492
Closed
tariq1890 wants to merge 2 commits intoonsi:masterfrom
Closed
remove the x/net context in favour of the stdlib context#1492tariq1890 wants to merge 2 commits intoonsi:masterfrom
tariq1890 wants to merge 2 commits intoonsi:masterfrom
Conversation
b98cfab to
6931da9
Compare
Owner
|
hey sorry - I had to force push to master to get rid of some accidentally committed test binaries. can you try to replace this diff on the latest master branch and make just the changes. thanks btw - that |
I generated the _test.go.{csv,json} files by using a version of ginkgo
built from the next commit.
If tests are run on this sha, they are expected to fail; the next
commit fixes them.
Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
6931da9 to
1f17433
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the usage of the
golang.org/x/netpackage (which has a HIGH severity CVE) and replaces it with a stdlib package instead