Skip to content

Add automaxprocs to automatically match the linux container CPU Quota#1543

Merged
onsi merged 1 commit intoonsi:masterfrom
emirot:add/automaxprocs
Apr 5, 2025
Merged

Add automaxprocs to automatically match the linux container CPU Quota#1543
onsi merged 1 commit intoonsi:masterfrom
emirot:add/automaxprocs

Conversation

@emirot
Copy link
Contributor

@emirot emirot commented Apr 2, 2025

What

Resolve issue #1542

@onsi onsi merged commit 91b11b8 into onsi:master Apr 5, 2025
6 checks passed
@onsi
Copy link
Owner

onsi commented Apr 6, 2025

hey - sorry for the confusion here. I pulled this in at first thinking it would be enough but then reverted it... did you check that this actually fixes the underlying issue in a linux container? My local machine is a mac and I haven't confirmed that this'll work. Moreover, Ginkgo uses runtime.NumCPU() to compute the number of CPUs - which.. I don't think is governed by GOMAXPROCS?

Can you confirm that pulling in automaxprocs this is working as you expect in a container? If not, you'll also need to adjust these two functions

@emirot
Copy link
Contributor Author

emirot commented Apr 6, 2025

@onsi Thanks for the feedback you were right I updated here is the new PR #1545

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants