Skip to content

fix(types): ignore nameless nodes on FullText()#1573

Merged
onsi merged 1 commit intoonsi:masterfrom
maxcleme:nameless-nodes
Aug 22, 2025
Merged

fix(types): ignore nameless nodes on FullText()#1573
onsi merged 1 commit intoonsi:masterfrom
maxcleme:nameless-nodes

Conversation

@maxcleme
Copy link
Contributor

We stumbled upon an issue where .FullText() was returning a leading space in the Spec name due to an empty Describe.

Not entirely sure if this behavior is intentional or not, but in any case, the pull request is ready if you’d like to take a look and consider accepting it 🙂

Signed-off-by: maxcleme <maximeclement93+github@gmail.com>
@maxcleme maxcleme marked this pull request as ready for review July 31, 2025 09:02
@onsi onsi merged commit 10866d3 into onsi:master Aug 22, 2025
6 checks passed
@onsi
Copy link
Owner

onsi commented Aug 22, 2025

hey sorry for the delay. thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants