Fix TextField selection stuck when target stops mouseUp propagation#2871
Open
Tutez64 wants to merge 1 commit into
Open
Fix TextField selection stuck when target stops mouseUp propagation#2871Tutez64 wants to merge 1 commit into
Tutez64 wants to merge 1 commit into
Conversation
Register stage_onMouseUp in capture phase so selection cleanup runs before target-phase listeners call stopImmediatePropagation(). Without this, MOUSE_MOVE stays active and text keeps selecting after release, which differs from Flash behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a Flash/AIR parity issue where
TextFieldtext selection could remain in a "mouse drag" state after the button was released.When application code adds a target-phase
mouseUplistener on aTextFieldand callsstopImmediatePropagation()(a pattern used in Flash UIs to isolate clicks from gameplay), OpenFL'sstage_onMouseUphandler never ran because it was registered on the stage in the bubble phase. The stageMOUSE_MOVElistener was never removed, so moving the pointer continued to extend the selection withoutbuttonDown.AIR did not show this behavior with the same listener setup.
Fix
Register and remove
stage_onMouseUpwithuseCapture = trueso selection teardown runs during the capture phase, before target listeners can stop propagation.Repro
OpenFLTextFieldMouseUpCaptureRepro.zip