Correct obsolete FSF address in all license notices#879
Conversation
pemensik
commented
Mar 4, 2026
Fixed with following sed script: s|License along with avahi; if not, see <https://www.gnu.org/licenses/>.|License along with avahi; if not, see <https://www.gnu.org/licenses/>.| /^[# ] Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307/ d /^[# ] USA./ d s|along with avahi; if not, see <https://www.gnu.org/licenses/>.|along with avahi; if not, see <https://www.gnu.org/licenses/>.| /^[# ] Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA./ d /^[# ] Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA/ d /^[# ] 02111-1307 USA./ d
|
Please add the rationale behind this change to the commit message. For example systemd/systemd@4a8c41f came with
|
|
Also I'm not sure I understand how that sed script turned <signature of Ty Coon>, 1 April 1990
Ty Coon, President of Viceto <signature of Moe Ghoul>, 1 April 1990
Moe Ghoul, President of Viceand where a bunch of other changes unrelated to the address came from. |
| # License along with avahi; if not, write to the Free Software | ||
| # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 | ||
| # USA. | ||
| # License along with avahi; if not, see <https://www.gnu.org/licenses/>. |
There was a problem hiding this comment.
If you're going to touch all the files like this anyway, you might consider adding an SPDX-License-Identifier: line to make it machine-readable as well. (Whether avahi wants SPDX, I don't know, this is a drive-by review).
The sample text on the FSF website at https://www.gnu.org/licenses/old-licenses/lgpl-2.1.txt is different from whenever LICENSE was first imported. Nowadays the sample text upstream actually says Moe Ghoul. Note that the SPDX license text sample for LGPL version 2.1 is the "old" one, which matches what is in the avahi repository. |
The commit message should mention that. Currently it just says that the sed script was run and that script couldn't change "Ty Coon" to "Moe Ghoul" obviously.
I think with |