integration-test: appease clippy#1590
Merged
Merged
Conversation
`useless_format` now flags `format!("{MARKER}")` as being equivalent to
`MARKER.to_string()`. We care more about symmetry here so suppress it.
✅ Deploy Preview for aya-rs-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Suppresses a new clippy::useless_format warning in the printk integration test by adding an #[expect] attribute, and converts the test's expected parameter from Vec<String> to a const-generic [String; N] array so the vec! macro is no longer needed.
Changes:
- Add
#[expect(clippy::useless_format, reason = "symmetry")]on thebpf_printktest. - Replace
vec![...]case inputs with array literals and generalize the test function withconst N: usize.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useless_formatnow flagsformat!("{MARKER}")as being equivalent toMARKER.to_string(). We care more about symmetry here so suppress it.This change is