App install: Handle invalid Git URLs better#426
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #426 +/- ##
==========================================
- Coverage 72.23% 72.22% -0.02%
==========================================
Files 18 18
Lines 1628 1631 +3
==========================================
+ Hits 1176 1178 +2
- Misses 452 453 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c188b1d to
45f3445
Compare
7c9aa8e to
3481fe1
Compare
3481fe1 to
155061c
Compare
3 tasks
danielhollas
commented
Apr 18, 2026
| elif re.match( | ||
| "fatal: Invalid object name", error_message, flags=re.IGNORECASE | ||
| ): | ||
| raise ValueError(f"Unknown commit: {self.commit}") |
Contributor
Author
There was a problem hiding this comment.
We don't know if the user was trying a specific commit, branch or tag so this error would be misleading.
Member
|
Hi @danielhollas. Where are we at on this one? |
Contributor
Author
|
Planning to finish today hopefully, then we can make a release.
…On Mon, Apr 20, 2026, 03:44 Edan Bainglass ***@***.***> wrote:
*edan-bainglass* left a comment (aiidalab/aiidalab#426)
<#426?email_source=notifications&email_token=ACIY64J46FR522DY5ES7NXT4WWFJ5A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMRXG42TEOJUGQZKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJNLQOJPWG33NNVSW45C7N5YGK3S7MNWGSY3L#issuecomment-4277529442>
Hi @danielhollas <https://github.com/danielhollas>. Where are we at on
this one?
—
Reply to this email directly, view it on GitHub
<#426?email_source=notifications&email_token=ACIY64J46FR522DY5ES7NXT4WWFJ5A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMRXG42TEOJUGQZKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJNLQOJPWG33NNVSW45C7N5YGK3S7MNWGSY3L#issuecomment-4277529442>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACIY64IEIBMNOSXNLABRX5L4WWFJ5AVCNFSM6AAAAACX2AJEHSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DENZXGUZDSNBUGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
Author
|
@edan-bainglass can you take a look again. Now I actually catch the exception so that the user doesn't see the horrible stacktrace from #396, which I guess was the original motivation to open the issue. Note the use of the term "git reference" because we don't know if the user meant to spell a branch, tag or a commit. EDIT: The failing tests are due the registry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #396