chore: widen cryptography constraint and bump CDK to 7.21.1#1044
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This PyAirbyte VersionYou can test this version of PyAirbyte using the following: # Run PyAirbyte CLI from this branch:
uvx --from 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1780715268-remove-cryptography-upper-bound' pyairbyte --help
# Install PyAirbyte from this branch for development:
pip install 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1780715268-remove-cryptography-upper-bound'PR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful ResourcesCommunity SupportQuestions? Join the #pyairbyte channel in our Slack workspace. |
|
Too much diff to scan? Review this PR in Change Stack to start with the highest-impact changes. Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe PR widens the ChangesDependency Relaxation
PyPI Publish Workflow
Sequence Diagram(s)sequenceDiagram
participant Trigger as GitHubEvent
participant Actions as GitHubActions
participant Runner as JobRunner
participant PyPI as PyPI
Trigger->>Actions: start from release or workflow_dispatch
Actions->>Runner: on dispatch checkout selected git_ref
Runner->>Runner: install uv and build with UV_DYNAMIC_VERSIONING_BYPASS
Runner->>PyPI: publish when release event or inputs.publish == 'true'
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Would you like me to suggest a brief PR checklist for testing dispatch runs locally or in a staging repo before merging? wdyt? 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code Coverage OverviewLanguages: Python Python / code-coverage/pytest-fastThe overall coverage in the branch is 67%. The coverage in the branch is 65%. Show a code coverage summary of the most impacted files.
Python / code-coverage/pytest-no-credsThe overall coverage in the branch is 67%. The coverage in the branch is 65%. Show a code coverage summary of the most impacted files.
Python / code-coverage/pytestThe overall coverage in the branch is 72%. The coverage in the branch is 71%. Show a code coverage summary of the most impacted files.
Updated |
|
|
|
|
Co-Authored-By: AJ Steers <aj@airbyte.io>
Co-Authored-By: AJ Steers <aj@airbyte.io>
…aint Co-Authored-By: AJ Steers <aj@airbyte.io>
Co-Authored-By: AJ Steers <aj@airbyte.io>
38ebf95 to
933daf6
Compare
|
/prerelease
|
There was a problem hiding this comment.
Pull request overview
This PR updates PyAirbyte’s Python dependency constraints to allow newer cryptography releases and updates the minimum required airbyte-cdk version, with the lockfile regenerated accordingly.
Changes:
- Relax
cryptographyconstraint from<45.0.0to a wider range (<47.0.0) while excluding45.0.0and45.0.1. - Raise the minimum
airbyte-cdkdependency to7.21.0.post4.dev27052511259. - Update
uv.lockto reflect the new dependency constraints and resolved versions.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| pyproject.toml | Updates runtime dependency constraints for cryptography and airbyte-cdk. |
| uv.lock | Regenerated lockfile reflecting the updated constraints and resolved airbyte-cdk version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: AJ Steers <aj@airbyte.io>
Co-Authored-By: AJ Steers <aj@airbyte.io>
Summary
Widens
cryptographyfrom>=44.0.0,<45.0.0to>=44.0.0,<47.0.0,!=45.0.0,!=45.0.1— the negation constraints exclude 45.0.0/45.0.1 which hadload_pem_private_key()regressions (fixed in 45.0.2+). PyAirbyte importscryptographydirectly inairbyte/_processors/sql/snowflake.pyfor key-pair auth, so we keep the explicit dependency.Bumps
airbyte-cdklower bound from>=7.3.9to>=7.21.1— CDK 7.21.1 includes the same widened cryptography constraint, so the two packages no longer conflict on resolution.Restores
workflow_dispatchtrigger topypi_publish.yml(removed by #944), which broke the/prereleaseslash command. Adds security hardening (persist-credentials: false, conditional cache disable) and uses SHA-pinned action references.Unblocks
boring-semantic-layer>=0.3.0in downstream projects (specificallyairbytehq/airbyte-transforms-poc) which transitively requirescryptography>=45.0.3.Link to Devin session: https://app.devin.ai/sessions/9f900ef4021147adb369727617d08827
Requested by: Aaron ("AJ") Steers (@aaronsteers)