Support decorating Mongoid::Criteria #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was looking for some sort of a single method I could override to decorate whenever the Criteria returns model instances, which would have been a much prettier solution. Unfortunately I could find one, so I overrode the methods I normally use in my views. Maybe someone can find a better way. |
|
+1 This is exactly what I was doing. Tested with Rails 4, Ruby 2 and Mongoid 4 (master branch). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added support for decorating Mongoid::Criteria objects. I usually do
@thing = Thing.alland the Mongoid::Criteria object that returns fails to get decorated when its passed to the view.