feat(terminal): redesign terminal pane toolbar with real icons#38
Open
kevmtt wants to merge 1 commit into
Open
feat(terminal): redesign terminal pane toolbar with real icons#38kevmtt wants to merge 1 commit into
kevmtt wants to merge 1 commit into
Conversation
Author
|
|
…ehmam#34) Replace the Unicode-glyph toolbar controls (+, caret, split glyphs, x) with stroke-based inline SVG icons, consolidate the two split buttons into a single Layout split-button with a dropdown, and fix the new-tab dropdown that was invisible. - New `icons.tsx`: small `currentColor` SVG icons (add, split, split-down, close, caret). - `SurfaceTabBar`: icon split-buttons (New / Layout / Close); dropdown menus rendered via portal so they aren't clipped. - Dropdown bug: `.surface-tab-bar` is height:28px + overflow:hidden, so the absolutely-positioned menu (top:30px) was clipped and never painted — rendering the menu in a portal fixes it. - Restyle the control cluster in `splitpane.css` (rounded hover pills, accent colors). Behavior, IPC, and store are unchanged.
31006f3 to
099239b
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Presentational redesign of the terminal pane toolbar, plus a fix for the invisible new-tab dropdown.
Closes #34
What & why
The toolbar used Unicode text glyphs (
+,▾, split glyphs,×) that render inconsistently across fonts, and the "new tab type" caret dropdown was invisible.currentColor, so hover accents come from CSS). New fileicons.tsx..surface-tab-barisheight: 28px; overflow: hidden, so the absolutely-positioned menu (top: 30px) was clipped and never painted. Menus now render via a portal, so both the New and Layout dropdowns are fully visible.Files
src/renderer/components/SplitPane/icons.tsx— new SVG icon components (add, split, split-down, close, caret)src/renderer/components/SplitPane/SurfaceTabBar.tsx— icon split-buttons + portal-rendered menussrc/renderer/styles/splitpane.css— control-cluster styling (rounded hover pills, accent colors), portal menu stylesdocs/superpowers/specs/2026-06-16-terminal-toolbar-redesign-design.md— design spec.gitignore— ignore the local.superpowers/tooling dirScope
PaneWrapperalready passesonNew,onNewTyped,onNewProfile,onSplitRight,onSplitDown,onClosePane.Test plan
tsc(renderer) cleanFollow-up
Icons are hand-rolled SVGs for now; migrating to
lucide-reactis a sensible future step (noted on #34). The icons live in one file to make that swap trivial.