[WIP] Async ORM#9
Open
nicolaslara wants to merge 48 commits into
Open
Conversation
They actually do as of this commit, and the middleware appears to work fine, but I'm sure there's some threading issues to be caught if nothing else.
…go#4) * Add decorator to mark middleware as async; fix middleware tests * Simplify async middleware decorator * Don't log about adapting middleware if DEBUG is false
…he unnecessary open threads
…ethods on ipython
… can be generalized
They actually do as of this commit, and the middleware appears to work fine, but I'm sure there's some threading issues to be caught if nothing else.
…go#4) * Add decorator to mark middleware as async; fix middleware tests * Simplify async middleware decorator * Don't log about adapting middleware if DEBUG is false
1df9d06 to
a22d053
Compare
9ecc9b4 to
2c1d742
Compare
c637aef to
f8d0904
Compare
f8d0904 to
ce8cfbf
Compare
c3a94e3 to
c86f88b
Compare
fe0ddbc to
97ead93
Compare
40ca60c to
fc0fa72
Compare
Author
|
@auvipy I was planning to work on this before covid, but I've been pretty low on time this year unfortunately, so I'm not sure any of the work on this branch is something we can reuse; it was more of an initial experiment at integrating an async db backend. There are probably easier ways to do this: implement an async backend with minimal changes to the internal backends, or start by buidling the async interface while wrapping the actual calls in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've started experimenting with allowing the ORM to make async calls to the DB. I am very slowly, but surely making progress.
This is far from ready, but I wanted to open this PR to provide visibility into what I'm doing.
My next steps are more or less:
connection.a.cursor().execute()) even make sense?Once that is done, I'll be in a position to start scoping out the work needed to move this forward and I'll post to the forum to get some discussions going (and hopefully recruit someone to help me with it)
(Some of my personal notes about the work can be found here: https://github.com/nicolaslara/django/blob/async_orm/orm_notes.md)
At the moment, this is implemented: