Skip to content

AAP-47455 Wait for pod complete and GetPodStatus#1372

Draft
arrestle wants to merge 26 commits into
ansible:develfrom
arrestle:wait-for-pod-complete
Draft

AAP-47455 Wait for pod complete and GetPodStatus#1372
arrestle wants to merge 26 commits into
ansible:develfrom
arrestle:wait-for-pod-complete

Conversation

@arrestle

@arrestle arrestle commented Jul 3, 2025 •
edited
Loading

Copy link
Copy Markdown

AAP-46619 Wait for pod complete

Broken out of #1368

  1. new helper function startNetceptorNodeWithWorkceptorWithLogger for testing debug statements with a special logger.
  2. Pod WaitForPodCompleted that waits for a pod modification to occur and returns. Debug captures a lot in case there are kubernetes abnormalities.

See Test Cases for details.

@codecov

codecov Bot commented Jul 8, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 88.88889% with 12 lines in your changes missing coverage. Please review.

Project coverage is 54.35%. Comparing base (a20b5ab) to head (80d2539).
Report is 2 commits behind head on devel.

Files with missing lines Patch % Lines
pkg/workceptor/pod.go 90.19% 8 Missing and 2 partials ⚠️
pkg/workceptor/kubernetes.go 66.66% 2 Missing ⚠️ 
@@            Coverage Diff             @@
##            devel    #1372      +/-   ##
==========================================
+ Coverage   52.46%   54.35%   +1.88%     
==========================================
  Files          59       63       +4     
  Lines        9826    10522     +696     
==========================================
+ Hits         5155     5719     +564     
- Misses       4362     4504     +142     
+ Partials      309      299      -10
Files with missing lines Coverage Δ
pkg/workceptor/kubernetes.go 52.46% <66.66%> (+8.65%) ⬆️
pkg/workceptor/pod.go 90.19% <90.19%> (ø)

... and 11 files with indirect coverage changes

Components Coverage Δ
Go 54.64% <88.88%> (+2.18%) ⬆️
Receptorctl 49.31% <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arrestle arrestle marked this pull request as draft July 8, 2025 11:06
@arrestle arrestle marked this pull request as ready for review July 9, 2025 12:37
@arrestle arrestle requested review from AaronH88, lranjbar and matoval July 9, 2025 12:38
Andrea Restle-Lay added 2 commits July 9, 2025 11:04
@sonarqubecloud

sonarqubecloud Bot commented Jul 9, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@arrestle arrestle marked this pull request as draft July 9, 2025 15:57
@arrestle arrestle changed the title AAP-46619 Wait for pod complete AAP-47455 Wait for pod complete and GetPodStatus Jul 9, 2025
@arrestle arrestle mentioned this pull request Aug 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AaronH88 AaronH88 Awaiting requested review from AaronH88

@lranjbar lranjbar Awaiting requested review from lranjbar

@matoval matoval Awaiting requested review from matoval

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@arrestle