src/routes/(console)/project-[region]-[project]/sites/site-[site]/deployments/createManualDeploymentModal.svelte (1)

24-27: Fix file size limit units and error handling

• maxSize: plan path converts MB→bytes, fallback path does not. Normalize to bytes for both.
• Show the dynamic limit in the error instead of a hardcoded “10MB”.
• Handle unknown in catch.

 $: maxSize =
-        isCloud && $currentPlan
-            ? $currentPlan.deploymentSize * 1000000
-            : $consoleVariables._APP_COMPUTE_SIZE_LIMIT; // already in MB
+        isCloud && $currentPlan
+            ? $currentPlan.deploymentSize * 1_000_000
+            : ($consoleVariables._APP_COMPUTE_SIZE_LIMIT ?? 0) * 1_000_000; // MB → bytes

-        } catch (e) {
-            error = e.message;
-            trackError(e, Submit.DeploymentCreate);
+        } catch (e) {
+            const msg = e instanceof Error ? e.message : String(e);
+            error = msg;
+            trackError(e, Submit.DeploymentCreate);
         }

-        } else if (reason === InvalidFileType.SIZE) {
-            error = 'File size exceeds 10MB';
+        } else if (reason === InvalidFileType.SIZE) {
+            error = `File size exceeds ${readableMaxSize.value}${readableMaxSize.unit}`;

Also applies to: 55-56, 45-47

src/routes/(console)/project-[region]-[project]/functions/function-[function]/(modals)/createManual.svelte (1)

23-27: Normalize file size units, dynamic message, and error typing

Same MB→bytes mismatch and static “10MB” string; also guard unknown in catch.

 $: maxSize =
-        isCloud && $currentPlan?.deploymentSize
-            ? $currentPlan.deploymentSize * 1000000
-            : $consoleVariables._APP_COMPUTE_SIZE_LIMIT; // already in MB
+        isCloud && $currentPlan?.deploymentSize
+            ? $currentPlan.deploymentSize * 1_000_000
+            : ($consoleVariables._APP_COMPUTE_SIZE_LIMIT ?? 0) * 1_000_000; // MB → bytes

-        } else if (reason === InvalidFileType.SIZE) {
-            error = 'File size exceeds 10MB';
+        } else if (reason === InvalidFileType.SIZE) {
+            error = `File size exceeds ${readableMaxSize.value}${readableMaxSize.unit}`;

-        } catch (e) {
-            error = e.message;
+        } catch (e) {
+            error = e instanceof Error ? e.message : String(e);
             trackError(e, Submit.DeploymentCreate);
         }

Also applies to: 55-56, 45-47

src/routes/(console)/project-[region]-[project]/sites/create-site/manual/+page.svelte (1)

46-50: Normalize file size limit units (MB→bytes)

Ensure fallback path is bytes like the plan path.

 $: maxSize =
         isCloud && $currentPlan
-            ? $currentPlan.deploymentSize * 1000000
-            : $regionalConsoleVariables._APP_COMPUTE_SIZE_LIMIT; // already in MB
+            ? $currentPlan.deploymentSize * 1_000_000
+            : ($regionalConsoleVariables._APP_COMPUTE_SIZE_LIMIT ?? 0) * 1_000_000; // MB → bytes

src/routes/(console)/project-[region]-[project]/functions/create-function/manual/+page.svelte (2)

169-173: Normalize file size limit units and message

Same MB→bytes normalization and dynamic error text.

 $: maxSize =
-        isCloud && $currentPlan
-            ? $currentPlan.deploymentSize * 1000000
-            : $regionalConsoleVariables._APP_COMPUTE_SIZE_LIMIT; // already in MB
+        isCloud && $currentPlan
+            ? $currentPlan.deploymentSize * 1_000_000
+            : ($regionalConsoleVariables._APP_COMPUTE_SIZE_LIMIT ?? 0) * 1_000_000; // MB → bytes

-        } else if (reason === InvalidFileType.SIZE) {
-            addNotification({
-                type: 'error',
-                message: 'File size exceeds 10MB'
-            });
+        } else if (reason === InvalidFileType.SIZE) {
+            addNotification({
+                type: 'error',
+                message: `File size exceeds ${readableMaxSize.value}${readableMaxSize.unit}`
+            });

Also applies to: 145-148

---

1-1: Verify and fix repo-wide inconsistencies in file size limit logic

The verification confirms multiple issues that need addressing:

1. Unit mismatch in maxSize computation: Files calculate maxSize = $currentPlan.deploymentSize * 1000000 (bytes) but fall back to $regionalConsoleVariables._APP_COMPUTE_SIZE_LIMIT (already in MB). This creates inconsistent units depending on the code path.

2. Hardcoded error messages misaligned with dynamic limits: Multiple files hardcode "File size exceeds 10MB" or "File size exceeds 5MB" in error messages, but maxSize is dynamically computed from plan data. Users see static messages that don't reflect the actual limit.

3. Inconsistent error strings across codebase: Error messages vary ("exceeds 10MB", "exceeds 5MB", "exceeds the limit") across different pages, preventing centralized updates.

Affected files:

• src/routes/(console)/project-[region]-[project]/functions/create-function/manual/+page.svelte (line 144, 166-169)
• src/routes/(console)/project-[region]-[project]/functions/function-[function]/(modals)/createManual.svelte (line 23-26, 55)
• src/routes/(console)/project-[region]-[project]/sites/create-site/manual/+page.svelte (line 46-49, 145)
• src/routes/(console)/project-[region]-[project]/sites/site-[site]/deployments/createManualDeploymentModal.svelte (line 24-27, 55)
• src/routes/(console)/organization-[organization]/domains/domain-[domain]/importRecordModal.svelte (line 47)

Consolidate size limit constants, ensure byte conversion is applied uniformly, and use dynamic values in user-facing error messages.

src/lib/stores/uploader.ts (2)

120-168: Add error handling to update deployment status on failure.

The method lacks error handling. If createDeployment throws an error, the deployment's status will remain 'pending' in the uploader UI instead of being marked as 'failed'. This leaves users without visual feedback about the failure.

Wrap the deployment call in a try-catch block:

         update((n) => {
             n.isOpen = true;
             n.isCollapsed = false;
             n.files.unshift(newDeployment);
             return n;
         });
-        const uploadedFile = await temporarySites(
-            page.params.region,
-            page.params.project
-        ).createDeployment({
-            siteId,
-            code,
-            activate: true,
-            buildCommand,
-            installCommand,
-            outputDirectory,
-            onProgress: (progress) => {
-                newDeployment.$id = progress.$id;
-                newDeployment.progress = progress.progress;
-                newDeployment.status = progress.progress === 100 ? 'success' : 'pending';
-                updateFile(progress.$id, newDeployment);
-            }
-        });
-        newDeployment.$id = uploadedFile.$id;
-        newDeployment.progress = 100;
-        newDeployment.status = 'success';
-        updateFile(newDeployment.$id, newDeployment);
+        try {
+            const uploadedFile = await temporarySites(
+                page.params.region,
+                page.params.project
+            ).createDeployment({
+                siteId,
+                code,
+                activate: true,
+                buildCommand,
+                installCommand,
+                outputDirectory,
+                onProgress: (progress) => {
+                    newDeployment.$id = progress.$id;
+                    newDeployment.progress = progress.progress;
+                    newDeployment.status = progress.progress === 100 ? 'success' : 'pending';
+                    updateFile(progress.$id, newDeployment);
+                }
+            });
+            newDeployment.$id = uploadedFile.$id;
+            newDeployment.progress = 100;
+            newDeployment.status = 'success';
+            updateFile(newDeployment.$id, newDeployment);
+        } catch (error) {
+            newDeployment.status = 'failed';
+            newDeployment.error = error.message || 'Deployment failed';
+            updateFile(newDeployment.$id, newDeployment);
+            throw error;
+        }
     },

---

169-208: Add error handling to update deployment status on failure.

Similar to uploadSiteDeployment, this method lacks error handling. If createDeployment throws, the deployment status remains 'pending' instead of showing 'failed', leaving users without proper failure feedback.

Wrap the deployment call in a try-catch block:

         update((n) => {
             n.isOpen = true;
             n.isCollapsed = false;
             n.files.unshift(newDeployment);
             return n;
         });
-        const uploadedFile = await temporaryFunctions(
-            page.params.region,
-            page.params.project
-        ).createDeployment({
-            functionId,
-            code,
-            activate: true,
-            onProgress: (progress) => {
-                newDeployment.$id = progress.$id;
-                newDeployment.progress = progress.progress;
-                newDeployment.status = progress.progress === 100 ? 'success' : 'pending';
-                updateFile(progress.$id, newDeployment);
-            }
-        });
-        newDeployment.$id = uploadedFile.$id;
-        newDeployment.progress = 100;
-        newDeployment.status = 'success';
-        updateFile(newDeployment.$id, newDeployment);
+        try {
+            const uploadedFile = await temporaryFunctions(
+                page.params.region,
+                page.params.project
+            ).createDeployment({
+                functionId,
+                code,
+                activate: true,
+                onProgress: (progress) => {
+                    newDeployment.$id = progress.$id;
+                    newDeployment.progress = progress.progress;
+                    newDeployment.status = progress.progress === 100 ? 'success' : 'pending';
+                    updateFile(progress.$id, newDeployment);
+                }
+            });
+            newDeployment.$id = uploadedFile.$id;
+            newDeployment.progress = 100;
+            newDeployment.status = 'success';
+            updateFile(newDeployment.$id, newDeployment);
+        } catch (error) {
+            newDeployment.status = 'failed';
+            newDeployment.error = error.message || 'Deployment failed';
+            updateFile(newDeployment.$id, newDeployment);
+            throw error;
+        }
     },