Add: in-row-editor navigation #2538

ItzNotABug · 2025-11-03T09:28:35Z

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

Summary by CodeRabbit

New Features
- Added up/down navigation controls in the row details panel to move between rows (disabled at first/last and hidden on tablet).
- Side panel header can now show additional top-right actions.
- Faster, more reliable row navigation/focus when browsing paginated tables.
Bug Fixes
- Improved handling of spatial-type values to prevent incorrect change detection.
Chores
- Updated UI package references and bumped the package manager version.

appwrite · 2025-11-03T09:28:40Z

Console

Project ID: 688b7bf400350cbd60e9

Sites (1)

Site	Status	Logs	Preview	QR
console-stage `688b7cf6003b1842c9dc`	Ready	View Logs	Preview URL

Tip

Cursor pagination performs better than offset pagination when loading further pages.

coderabbitai · 2025-11-03T09:31:26Z

Walkthrough

This pull request updates package dependencies (pnpm 10.15.1 → 10.20.0 and @appwrite.io icons/svelte and pink-svelte references to new v1 hash d94920e) and introduces UI, store, and spreadsheet changes for row navigation and indexing. Changes include: new up/down chevron navigation controls in the row SideSheet (rendered only on non-tablet viewports) via a new topEndActions prop on the SideSheet component; a reactive rowIndexMap for O(1) row lookups and inclusion of rowIndex and rows (paginatedRows.items) in databaseRowSheetOptions updates; store type and initial value extensions to include rows and rowIndex; and spatial-type equality handling using deep-equal in the row edit comparison logic.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Review reactive rowIndexMap rebuild and correctness when paginatedRows.items changes, including missing IDs and pagination boundaries.
Validate databaseRowSheetOptions type change and initial values; ensure all callers handle new rows and rowIndex fields and that update payloads consistently carry paginatedRows.items.
Verify SideSheet API change (new topEndActions prop and footer type change) is correctly used and does not break existing consumers.
Confirm ChevronUp/ChevronDown navigation updates rowIndex and row state correctly and are disabled at boundaries; ensure viewport gating with isTabletViewport behaves as intended.
Inspect compareColumns change: ensure deep-equal usage for spatial types is correct and that spatial-type detection (isSpatialType) covers all relevant column shapes.

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title 'Add: in-row-editor navigation' directly aligns with the primary changes in the changeset. The modifications introduce up/down navigation controls in the row editor (via ChevronUp/ChevronDown buttons in the sidesheet) that allow users to move between rows. This is evidenced by new icon imports, navigation control logic, and store updates for tracking row indices and multiple rows. The title accurately captures the main feature being added.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch add-arrow-navs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ea56166 and d7e19c1.

📒 Files selected for processing (2)

src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/rows/edit.svelte (2 hunks)
src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/spreadsheet.svelte (3 hunks)

🧰 Additional context used

🧠 Learnings (5)

📚 Learning: 2025-09-30T07:41:06.679Z

Learnt from: ItzNotABug
Repo: appwrite/console PR: 2425
File: src/routes/(console)/project-[region]-[project]/databases/database-[database]/(suggestions)/empty.svelte:454-468
Timestamp: 2025-09-30T07:41:06.679Z
Learning: In `src/routes/(console)/project-[region]-[project]/databases/database-[database]/(suggestions)/empty.svelte`, the column suggestions API (console.suggestColumns) has a maximum limit of 7 columns returned, which aligns with the initial placeholder count of 7 in customColumns.

Applied to files:

src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/rows/edit.svelte
src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/spreadsheet.svelte

📚 Learning: 2025-10-07T14:17:11.597Z

Learnt from: ItzNotABug
Repo: appwrite/console PR: 2413
File: src/routes/(console)/project-[region]-[project]/databases/database-[database]/(entity)/helpers/terminology.ts:28-28
Timestamp: 2025-10-07T14:17:11.597Z
Learning: In src/routes/(console)/project-[region]-[project]/databases/database-[database]/(entity)/helpers/terminology.ts, the empty `vectordb: {}` entry in baseTerminology is intentional. The vectordb database type is not currently used because the backend API is not finalized, and no database type returns 'vectordb' at the moment.

Applied to files:

src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/rows/edit.svelte

📚 Learning: 2025-09-25T04:21:57.071Z

Learnt from: ItzNotABug
Repo: appwrite/console PR: 2373
File: src/routes/(console)/project-[region]-[project]/databases/database-[database]/(suggestions)/empty.svelte:536-552
Timestamp: 2025-09-25T04:21:57.071Z
Learning: In the Appwrite console database suggestions flow, after successfully creating columns via `createColumns()`, the `await invalidate(Dependencies.TABLE)` call causes the view to be destroyed and another view (populated table view) to be rendered, automatically cleaning up component state without needing manual reset.

Applied to files:

src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/rows/edit.svelte

📚 Learning: 2025-09-04T03:59:03.485Z

Learnt from: ItzNotABug
Repo: appwrite/console PR: 2290
File: src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/spreadsheet.svelte:952-961
Timestamp: 2025-09-04T03:59:03.485Z
Learning: In the Appwrite console spreadsheet component, for relationship columns, the columnId corresponds to the tableId of the related table. When calling openSideSheetForRelationsToMany(tableId, rows), the columnId can be passed directly as the tableId parameter for relationship columns.

Applied to files:

src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/rows/edit.svelte

📚 Learning: 2025-10-13T05:16:07.656Z

Learnt from: ItzNotABug
Repo: appwrite/console PR: 2413
File: src/routes/(console)/project-[region]-[project]/databases/database-[database]/header.svelte:54-58
Timestamp: 2025-10-13T05:16:07.656Z
Learning: In SvelteKit apps, shared layout components (like headers) that use `$derived(page.data.*)` should use optional chaining when accessing properties that may not be present on all routes. During page transitions, reactive statements can briefly evaluate with different page.data structures, so optional chaining prevents runtime errors when navigating between routes with different data shapes (e.g., between `/databases` and `/databases/database-[database]`).

Applied to files:

src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/rows/edit.svelte

...e)/project-[region]-[project]/databases/database-[database]/table-[table]/spreadsheet.svelte

ItzNotABug added 2 commits November 3, 2025 14:31

add: in-row-editor navigation.

1fd2442

fix: shortcut not working.

ea56166

fix: missing spatial deep check.

d7e19c1

HarshMN2345 approved these changes Nov 3, 2025

View reviewed changes

coderabbitai bot reviewed Nov 3, 2025

View reviewed changes

...e)/project-[region]-[project]/databases/database-[database]/table-[table]/spreadsheet.svelte Show resolved Hide resolved

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add: in-row-editor navigation #2538

Add: in-row-editor navigation #2538

Uh oh!

ItzNotABug commented Nov 3, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

appwrite bot commented Nov 3, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Nov 3, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add: in-row-editor navigation #2538

Are you sure you want to change the base?

Add: in-row-editor navigation #2538

Uh oh!

Conversation

ItzNotABug commented Nov 3, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Test Plan

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

Summary by CodeRabbit

Uh oh!

appwrite bot commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Console

Uh oh!

coderabbitai bot commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

Pre-merge checks and finishing touches

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ItzNotABug commented Nov 3, 2025 •

edited by coderabbitai bot

Loading

appwrite bot commented Nov 3, 2025 •

edited

Loading

coderabbitai bot commented Nov 3, 2025 •

edited

Loading