Skip to content

fix: show scroll-to-top/bottom controls in deployment logs #2554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: show scroll-to-top/bottom controls in deployment logs #2554

wants to merge 1 commit into from
+1 −1

Conversation

@HarshMN2345
Copy link
Member

@HarshMN2345 HarshMN2345 commented Nov 4, 2025 •
edited by coderabbitai bot
Loading

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

Summary by CodeRabbit

  • Bug Fixes
    • Scroll buttons are now visible in the deployment logs section, enabling easier navigation through log entries.

@appwrite
Copy link

appwrite bot commented Nov 4, 2025 •
edited
Loading

Console

Project ID: 688b7bf400350cbd60e9

Sites (1)
Site Status Logs Preview QR
 console-stage
688b7cf6003b1842c9dc		 Ready Ready View Logs Preview URL QR Code

Tip

Appwrite has a Discord community with over 16 000 members.

@HarshMN2345 HarshMN2345 marked this pull request as ready for review November 4, 2025 11:34
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 4, 2025 •
edited
Loading

Walkthrough

A prop was removed from the Logs component in the Deployment logs accordion within the deployment detail page. The hideScrollButtons prop was removed from the Logs component invocation, changing from <Logs {deployment} hideTitle hideScrollButtons fullHeight /> to <Logs {deployment} hideTitle fullHeight />. This modification will alter the visual behavior to display scroll buttons in the logs view instead of hiding them.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single prop removal in one component usage
  • No changes to logic or business functionality
  • Straightforward visual behavior modification

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing the hideScrollButtons prop to show scroll controls in deployment logs.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat-add-scrollButtons-in-logs
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c5fd02a and 2e9e4be.

📒 Files selected for processing (1)
  • src/routes/(console)/project-[region]-[project]/sites/site-[site]/deployments/deployment-[deployment]/+page.svelte (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build
  • GitHub Check: e2e
🔇 Additional comments (1)
src/routes/(console)/project-[region]-[project]/sites/site-[site]/deployments/deployment-[deployment]/+page.svelte (1)

86-86: Change verified and correct.

Removing the hideScrollButtons prop properly enables scroll buttons in the deployment logs. The Logs component defaults to hideScrollButtons = false, which inverts to showScrollButton={true} on the underlying component, displaying the scroll-to-top/bottom controls as intended.

Other Logs usages in the codebase are either:

  • The pink-svelte Logs component (logsResponse.svelte, viewLogsModal.svelte), which accepts different props
  • The create-site deploying page, which intentionally hides scroll buttons for that specific deployment flow

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Meldiron Meldiron Meldiron approved these changes

@ItzNotABug ItzNotABug ItzNotABug approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HarshMN2345 @Meldiron @ItzNotABug