Skip to content

[Gemini] update deps and resolve small compile errors #11

@z-tech

Description

@z-tech

Synopsis:

First I noticed gemini -> main compile fails:

error: failed to load source for dependency `ark-ec`

Caused by:
  Unable to update https://github.com/mmaker/algebra?branch=feature/additive-groups#1419b95a

Then I noticed the PR merged on May 10, 2023 arkworks-rs/algebra <- feature/additive-groups

I updated cargo.toml to point to arkworks-rs/algebra -> main and resolved some tiny type errors like these:

fn advance_by(&mut self, n: usize) -> Result<(), usize> {
                                            ^^^^^^^^^^^^^^^^^
                                            expected `core::num::NonZeroUsize`, found `usize`
                                            help: change the output type to match the trait: `core::result::Result<(), core::num::NonZeroUsize>`

Result:

  • no compile errors for cargo test, cargo rustdoc --open, cargo run --features asm,print-trace,parallel --example snark -- -i 4
  • tests pass, benches work

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions