Draft
Conversation
Co-authored-by: =?UTF-8?q?Jakub=20Koz=C5=82owski?= <kubukoz@gmail.com>
kubukoz
reviewed
Apr 17, 2023
| /** | ||
| * A reified modifier | ||
| */ | ||
| trait Mod[F[_], E]: |
Collaborator
There was a problem hiding this comment.
Can we make E a type member and point it to Node[F]?
Owner
Author
There was a problem hiding this comment.
I'd rather not, esp. if I go forward with proposed changes in #180 so that modifiers can only be applied to elements/nodes on which they are valid. Right now it's a bit wild west.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #207.
This PR introduces
Mod[IO, Elem]which reifies modifier, as well as a.toModsyntax.This would make it possible to write:
instead of
and generally make it easier to pass modifiers around.
I'm not entirely sold on this yet, since it moves in the direction that
Modifiershould not be a typeclass, which in turn was motivated so that a.toModextension wouldn't be needed for stuff likeStringorHtmlElement. But if we're going to do that anyway, then maybe we should change the encoding.h/t @kubukoz, cc @yurique