Fix: Issue 223 - improve embedded input warning#437
Open
RhettPoole wants to merge 2 commits into
Open
Conversation
…project#223), also adds test case for a type with no inputs.
…project#223), also adds test case for a type with no inputs.
Contributor
|
👋 two things:
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Leave anything that you believe does not apply unchecked.
Summary
Improves the warning when an embedded type is used as GraphQL input but no input fields are produced (example used in test case is an empty 'accept' on create/update) instead of using the cryptic warning described in the initial issue description.
Related Issue
Fixes #223
Behavior
Warning text only; fallback to 'json_type' / ':json_string' is unchanged.
Testing
'mix test test/issue_223_repro_test.exs'
Full suite in WSL was tested as well.