WIP - Auto js fixtures#3649
Draft
n0izn0iz wants to merge 2 commits into
Draft
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3649 +/- ##
==========================================
- Coverage 29.84% 29.81% -0.03%
==========================================
Files 378 378
Lines 32663 32679 +16
Branches 1752 1752
==========================================
- Hits 9747 9744 -3
- Misses 21642 21658 +16
- Partials 1274 1277 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
43a3ae5 to
c8dba3f
Compare
added 2 commits
November 10, 2021 17:12
Signed-off-by: Norman Meier <norman@berty.tech>
Signed-off-by: Norman Meier <norman@berty.tech>
c8dba3f to
f46b856
Compare
|
This PR/issue depends on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #3650
The auto fixtures feature works but there will be problems with generating them consistently:
I won't merge it for now because if it were used, it would require regenerating all snapshots on fixtures regen which would produce a lot of review noise and discourage snapshots diff reviews