Skip to content

fix(messenger): don't dispatch useless member updates#3837

Draft
n0izn0iz wants to merge 1 commit into
berty:masterfrom
n0izn0iz:no-useless-memberupdated
Draft

fix(messenger): don't dispatch useless member updates#3837
n0izn0iz wants to merge 1 commit into
berty:masterfrom
n0izn0iz:no-useless-memberupdated

Conversation

@n0izn0iz

@n0izn0iz n0izn0iz commented Dec 31, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

also wraps multiMemberGroupInitialMemberAnnounced handler in tx

@n0izn0iz n0izn0iz self-assigned this Dec 31, 2021
@n0izn0iz n0izn0iz requested review from a team and moul as code owners December 31, 2021 09:03
@auto-add-label auto-add-label Bot added the bug type: something isn't working label Dec 31, 2021
@codecov

codecov Bot commented Dec 31, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3837 (f4e4e5b) into master (c1034dd) will decrease coverage by 0.00%.
The diff coverage is 4.30%.

❗ Current head f4e4e5b differs from pull request most recent head 7ef1178. Consider uploading reports for the commit 7ef1178 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3837      +/-   ##
==========================================
- Coverage   29.88%   29.88%   -0.01%     
==========================================
  Files         403      403              
  Lines       34205    34206       +1     
  Branches     1902     1903       +1     
==========================================
  Hits        10222    10222              
- Misses      22665    22666       +1     
  Partials     1318     1318
Flag Coverage Δ
js.unittests 12.06% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
go/internal/messengerpayloads/handlers.go 0.00% <0.00%> (ø)
js/packages/redux/reducers/messenger.reducer.ts 26.39% <0.00%> (-0.14%) ⬇️
go/internal/messengerdb/db.go 60.20% <14.28%> (ø)
go/pkg/bertymessenger/testing.go 76.31% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1034dd...7ef1178. Read the comment docs.

@n0izn0iz n0izn0iz force-pushed the no-useless-memberupdated branch from 3412f68 to f4e4e5b Compare December 31, 2021 10:07
fix(messenger): don't dispatch useless member updates
7ef1178 
Signed-off-by: Norman Meier <norman@berty.tech>
@n0izn0iz n0izn0iz force-pushed the no-useless-memberupdated branch from f4e4e5b to 7ef1178 Compare December 31, 2021 10:35
@n0izn0iz n0izn0iz changed the title fix: don't dispatch useless member updates fix(messenger): don't dispatch useless member updates Dec 31, 2021
@jefft0 jefft0 removed the request for review from moul March 23, 2023 09:36
@jefft0 jefft0 removed request for a team April 19, 2023 08:31
@jefft0 jefft0 removed the bug type: something isn't working label Aug 7, 2023
@jefft0

jefft0 commented Oct 6, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@jefft0 to ask if this is still relevant.

@jefft0

jefft0 commented Oct 20, 2023

Copy link
Copy Markdown
Collaborator

n0izn0iz says: "This PR could still be relevant. This is an optimization so it doesn't trigger "state changes" and thus logic + rerenders in the front. But it's not very important I believe."

@jefft0

jefft0 commented Oct 27, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Keep open because of the comment from n0izn0iz. Not a high priority, and not a bug. Put in draft.

@jefft0 jefft0 added backlog and removed backlog labels Oct 27, 2023
@jefft0 jefft0 marked this pull request as draft October 27, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@n0izn0iz @jefft0