_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

• 📝 Generate docstrings

crates/biome_js_analyze/src/lint/correctness/no_unused_private_class_members.rs (2)

297-315: Per-node allocation in hot loop

get_destructured_names_from_this is invoked for every non-AnyJsName descendant, which is the vast majority of nodes. Each call performs two cast_ref attempts and allocates a Vec. A cheap kind-check guard would avoid most of this work.

Suggested guard

                 // Handle destructuring from `this`, e.g. `const { myVar } = this;`
+                if matches!(
+                    node.kind(),
+                    JsSyntaxKind::JS_VARIABLE_DECLARATOR | JsSyntaxKind::JS_ASSIGNMENT_EXPRESSION
+                ) {
                 let destructured_names = get_destructured_names_from_this(&node);
                 if !destructured_names.is_empty() {
                     private_members.retain(|private_member| {
                         let Some(name) = private_member.member_name() else {
                             return true;
                         };

                         if !destructured_names.iter().any(|n| n.text() == name.text()) {
                             return true;
                         }

                         if !private_member.is_private_sharp() {
                             ts_private_count -= 1;
                         }

                         false
                     });
                 }
+                }

Based on learnings: "Avoid string allocations by using &str or TokenText for comparisons instead of calling to_string()" — the TokenText usage is fine, but the repeated Vec allocation on every node is the concern here.

---

634-666: Duplication with match_js_name and property_range

All three methods (member_name, match_js_name, property_range) repeat the same four-arm match over class member kinds. Consider extracting a shared helper that returns the AnyJsClassMemberName, letting each caller do its own final step. Not urgent — the existing code already had this pattern — but now there are three copies.

• X
• Mastodon
• Reddit
• LinkedIn