Skip to content

feat(markdown): port snapshots from prettier#9067

Merged
ematipico merged 2 commits intobiomejs:mainfrom
tidefield:add-snapshots-for-markdown
Feb 16, 2026
Merged

feat(markdown): port snapshots from prettier#9067
ematipico merged 2 commits intobiomejs:mainfrom
tidefield:add-snapshots-for-markdown

Conversation

@tidefield
Copy link
Contributor

@tidefield tidefield commented Feb 14, 2026 •
edited
Loading

Summary

This PR continues the work discussed in #3718. It adds the snapshots from prettier by calling into the script crates/biome_formatter_test/src/prettier/prepare_tests.js.

Initially, I implemented prettier_tests.rs to generate *.md.snap in this PR. However, it became hard to review on Github because it has more than 1000 files changed and Github only shows 1000 files.

So I scoped the rust part into a separate branch. tidefield#5 has the prettier_tests.rs implementation along with *.md.snap generated by the tests.

Test Plan

Testing will be done after this PR is merged so I can rebase tidefield#5 to make a biome PR.

@changeset-bot
Copy link

changeset-bot bot commented Feb 14, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: b251b15

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the A-Formatter Area: formatter label Feb 14, 2026
@tidefield tidefield mentioned this pull request Feb 14, 2026
Open
@ematipico
Copy link
Member

ematipico commented Feb 14, 2026 •
edited
Loading

Ah, now it gets fun... we have a workflow that lints markdown files. It was mostly meant to target changesets. Now that we're about to add a lot of stuff, maybe we should update the workflow, and make sure we lint only files inside .changesets

Hopefully we will remove it soon-ish using our infrastructure

@jfmcdowell jfmcdowell mentioned this pull request Feb 14, 2026
Open
@github-actions github-actions bot added A-Project Area: project A-Parser Area: parser labels Feb 15, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 15, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 58 untouched benchmarks
⏩ 96 skipped benchmarks1

Comparing tidefield:add-snapshots-for-markdown (4150a51) with next (1da1356)

Open in CodSpeed

Footnotes

  1. 96 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@tidefield tidefield force-pushed the add-snapshots-for-markdown branch 2 times, most recently from 529597c to 6e136ff Compare February 15, 2026 06:53
@tidefield tidefield changed the title Add snapshots for Markdown feat(markdown): port snapshot tests from prettier Feb 15, 2026
@tidefield tidefield force-pushed the add-snapshots-for-markdown branch from 678c603 to c869c90 Compare February 15, 2026 07:08
@tidefield tidefield force-pushed the add-snapshots-for-markdown branch from 4150a51 to 46aae4b Compare February 15, 2026 11:26
@github-actions github-actions bot added A-LSP Area: language server protocol and removed A-Parser Area: parser labels Feb 15, 2026
@tidefield tidefield changed the base branch from next to main February 15, 2026 11:27
@tidefield tidefield marked this pull request as ready for review February 15, 2026 11:36
@github-actions github-actions bot removed A-Project Area: project A-LSP Area: language server protocol labels Feb 15, 2026
@tidefield
Copy link
Contributor Author

tidefield commented Feb 15, 2026

@ematipico I fixed the markdown linter on CI. The PR is ready for review. This PR doesn't do anything beside adding the .md and .prettier-snap files. I originally added the prettier tests to generate .snap but the PR is too big for the relevant parts to be reviewable on Github. So I scoped that into a different branch tidefield#5.

@tidefield
Copy link
Contributor Author

tidefield commented Feb 15, 2026

@jfmcdowell do you mind holding on #9070 until I merged this PR and tidefield#5 which implement the prettier tests? It has some overlap with your PR.

@tidefield tidefield changed the title feat(markdown): port snapshot tests from prettier feat(markdown): port snapshots from prettier Feb 15, 2026
@ematipico ematipico merged commit e332a23 into biomejs:main Feb 16, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ematipico ematipico ematipico approved these changes

Assignees

No one assigned

Labels

A-Formatter Area: formatter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tidefield @ematipico