Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where coverage values did not sum to num_trees when using out-of-bag (OOB) or in-bag sampling options in the forde function. The fix adds normalization to ensure coverage values sum to 1.0 per tree.
Changes:
- Added normalization step for coverage calculation in OOB and in-bag modes
- Added comprehensive test to verify coverage values sum correctly across all three modes (default, OOB, in-bag)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| R/forde.R | Added normalization cvg := cvg/sum(cvg), by = tree for both OOB (line 246) and in-bag (line 255) modes to ensure coverage values sum to 1.0 per tree |
| tests/testthat/test-return_types.R | Added test case verifying that coverage values sum to num_trees across all three sampling modes (default, OOB, in-bag) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coverages did not sum to num_trees when oob = T or oob = "inbag" was used. Fix with this PR.