Add max age to HLS CORS preflight responses#5759
Draft
modeitsch wants to merge 1 commit into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5759 +/- ##
==========================================
+ Coverage 63.06% 63.09% +0.02%
==========================================
Files 217 217
Lines 18364 18365 +1
==========================================
+ Hits 11581 11587 +6
+ Misses 5841 5836 -5
Partials 942 942 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5755.
This adds
Access-Control-Max-Age: 86400to HLS CORS preflight responses so browsers can cache successful preflight checks instead of sending an OPTIONS request before every segment request.The existing HLS preflight test now verifies the new header.
Tests:
go test ./internal/servers/hls -run TestServerPreflightRequest -count=1go test ./internal/servers/hls -count=1