Add staircase creation functionality#271
Open
Stypox wants to merge 3 commits into
Open
Conversation
Co-authored-by: Degra02 <filippodegrandi02@gmail.com> Co-authored-by: Alessio Zeni <alessio.zeni01@gmail.com> Co-authored-by: Dennis Orlando <dennis.orlando2002@gmail.com>
7ea2011 to
3366509
Compare
Member
|
Hi! It just occured to me that we never reponded to this, so: Thanks, this is extremely cool and something we have wanted to build for a long time! We haven't overlooked it but are waiting for a good time to merge this with all the other revamps we are currently doing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a button to the Stairs page that allows adding multiple parallel stairs at once (i.e. a staircase):
Even strange staircase shapes are supported (the stairs are created all parallel to the first edge in the polygon):
I am not completely sure about some of the changes I made, and I am happy to improve on them if I receive feedback:
/editor/spaces/{SPACE}/stairs/createendpoint.editor/edit.htmlrendered byedit()withmodel=apps.get_model('mapdata', 'Stair')), I added a special case inedit()that renders a different HTML page if the staircase endpoint is provided.Let me know your thoughts.
Note: this code was initially written during a Hackathon together with @dennisorlando @Degra02 @Usioumeo. The hackathon was organized by NOI, which also hosts SFScon, which uses c3nav for navigation during the conference.