Use long dtype for indexing and stdlib quicksort#9
Open
marscher wants to merge 12 commits intocwehmeyer:masterfrom
Open
Use long dtype for indexing and stdlib quicksort#9marscher wants to merge 12 commits intocwehmeyer:masterfrom
marscher wants to merge 12 commits intocwehmeyer:masterfrom
Conversation
* memberships are long (to encode -1) * used boolean types to indicate halo/border memberships * replaced rude quicksort impl with stdlib (breaks the reference test comparision). * reformatted code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably fixes #8 by replacing int based indexing (2**32 -1 points) via long. Also used bool wherever possible to make code more readable (also pep8 and reformatted c code a bit). The mixed sort routine has been replaced in favor of the stdlib impl of quick sort (which is likely more optimized).