Skip to content

Add opt-in accessibility artifact record and verify support#2278

Open
colinmarsch wants to merge 1 commit into
cmarsch/a11y-artifact-plumbingfrom
cmarsch/a11y-artifact-optin-core
Open

Add opt-in accessibility artifact record and verify support#2278
colinmarsch wants to merge 1 commit into
cmarsch/a11y-artifact-plumbingfrom
cmarsch/a11y-artifact-optin-core

Conversation

@colinmarsch

@colinmarsch colinmarsch commented Feb 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This change adds opt-in functionality (behind a gradle configuration property) to handle recording and verifying an accessibility hierarchy json string artifact for the #2239 feature.

Example output as follows:

[
  {
    "id": "Number 1",
    "beforeElementId": null,
    "afterElementId": "Number 2",
    "bounds": {
      "left": 57,
      "top": 57,
      "right": 215,
      "bottom": 616
    },
    "legendText": "Number 1"
  },
  {
    "id": "Number 2",
    "beforeElementId": "Number 1",
    "afterElementId": "Number 3",
    "bounds": {
      "left": 57,
      "top": 680,
      "right": 215,
      "bottom": 1239
    },
    "legendText": "Number 2"
  },
  {
    "id": "Number 3",
    "beforeElementId": "Number 2",
    "afterElementId": null,
    "bounds": {
      "left": 57,
      "top": 1303,
      "right": 215,
      "bottom": 1863
    },
    "legendText": "Number 3"
  }
]

@colinmarsch colinmarsch changed the title Add opt-in accessibility artifact record and verify support WIP: Add opt-in accessibility artifact record and verify support Feb 12, 2026
@colinmarsch colinmarsch force-pushed the cmarsch/a11y-artifact-optin-core branch from 786f7fd to c6465a6 Compare February 12, 2026 02:23
@colinmarsch colinmarsch mentioned this pull request Feb 12, 2026
Open
@colinmarsch colinmarsch marked this pull request as ready for review February 12, 2026 20:44
@colinmarsch colinmarsch changed the title WIP: Add opt-in accessibility artifact record and verify support Add opt-in accessibility artifact record and verify support Feb 12, 2026
@colinmarsch colinmarsch mentioned this pull request Feb 12, 2026
Open
oldergod
oldergod approved these changes May 13, 2026
View reviewed changes
Comment thread paparazzi/src/main/java/app/cash/paparazzi/HtmlReportWriter.kt
imagesDirectory.mkdirs()
videosDirectory.mkdirs()
reportArtifactsDirectory.mkdirs()
goldenArtifactsDirectory.mkdirs()

@oldergod oldergod May 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This creates a folder unconditionally during initialization in all cases but this mutates the snapshot root just by constructing the writer, regardless of whether artifact recording is enabled or any artifact is written. goldenFile.parentFile.mkdirs() inside the isRecording below is good enough I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oldergod oldergod oldergod approved these changes

@jrodbx jrodbx Awaiting requested review from jrodbx

@geoff-powell geoff-powell Awaiting requested review from geoff-powell

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@colinmarsch @oldergod