fix domain error message of 2-ary log#1048
Merged
Merged
Conversation
3 tasks
mflatt
requested changes
Jun 8, 2026
When `log` is called with exact `1` as the second argument, it results in a division by zero, which was reported in `/`. Report this error in terms of `log`, instead.
mflatt
approved these changes
Jun 8, 2026
Contributor
|
Thanks! |
mflatt
pushed a commit
to racket/racket
that referenced
this pull request
Jun 8, 2026
For `/`, say "division by zero"; for `log`, say either "undefined for
0" or "undefined for base 1"; for other functions, say "undefined for
<x> (and <y>)". Also, correct function names for `atan` and
`quotient/remainder` on CS, and correct printing of `-0.0` in
`quotient{,/remainder}` on BC.
Update tests to include the error message strings, and add missing
specs for raising of `exn:fail:contract:divide-by-zero` in docs.
The base-one error message in `log` on CS requires
cisco/ChezScheme#1048.
Fix #5527.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
logis called with exact1as the second argument, it results in a division by zero, which was reported in/. Report this error in terms oflog, instead.