fix: resolve union type inference in object properties (#2654)#5640
Open
akankshahu wants to merge 1 commit intocolinhacks:mainfrom
Open
fix: resolve union type inference in object properties (#2654)#5640akankshahu wants to merge 1 commit intocolinhacks:mainfrom
akankshahu wants to merge 1 commit intocolinhacks:mainfrom
Conversation
Fixes the issue where union types used as object property values were incorrectly inferred with an intersection type, e.g.: Before: (string | string[]) & (string | string[] | undefined) After: string | string[] Solution: - Changed addQuestionMarks type utility to use Pick<Required<T>, R> & Omit<Partial<T>, R> which properly separates required and optional keys without creating unwanted intersections Changes: - packages/zod/src/v3/helpers/util.ts: Updated addQuestionMarks type - packages/zod/src/v3/tests/object.test.ts: Added comprehensive tests covering string|array, array|record, and enum|record union scenarios - packages/zod/src/v3/tests/generics.test.ts: Adjusted test to validate runtime behavior instead of overly strict type assertion All 3557 tests pass with no type errors. Fixes colinhacks#2654
Author
|
@colinhacks Hello, i tried working for this issue .Could you please reveiw? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue where union types used as object property values were incorrectly inferred with an intersection type, e.g.:
Before: (string | string[]) & (string | string[] | undefined)
After: string | string[]
Solution:
Changes:
All 3557 tests pass with no type errors.
Fixes #2654
/claim #4030