fix: apply default values for missing tuple elements#5661
Open
Cyjin-jani wants to merge 2 commits intocolinhacks:mainfrom
Open
fix: apply default values for missing tuple elements#5661Cyjin-jani wants to merge 2 commits intocolinhacks:mainfrom
Cyjin-jani wants to merge 2 commits intocolinhacks:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Medium priority — The fix correctly addresses the reported issue for .default() but misses .prefault(), which has identical default-providing semantics. This is a real edge case that users could hit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5229
When parsing tuples with missing trailing elements that have
.default()values, the default values were not being applied. Instead, the elements were simply skipped.Before (As-is)
After (To-be)
Changes
Modified the tuple parsing logic to run the schema for default type elements even when the input array is shorter, allowing $ZodDefault to apply its default value.
File: packages/zod/src/v4/core/schemas.ts
Test Plan
✅ Added test case for tuple with default elements in tuple.test.ts
✅ All existing tests pass
Verified Issue Examples
All examples from #5229 now work correctly: