fix(v4): JSON schema min/max intersection for draft-04 and openapi-3.0#5700
Open
ebroder wants to merge 1 commit intocolinhacks:mainfrom
Open
fix(v4): JSON schema min/max intersection for draft-04 and openapi-3.0#5700ebroder wants to merge 1 commit intocolinhacks:mainfrom
ebroder wants to merge 1 commit intocolinhacks:mainfrom
Conversation
When both minimum and exclusiveMinimum exist (e.g., from .int().positive()), the conversion now picks the more restrictive constraint. Previously, the inclusive minimum would overwrite the exclusive one, producing incorrect output like `minimum: -9007199254740991` instead of `minimum: 0`. Same fix applied for maximum/exclusiveMaximum.
5 tasks
Contributor
There was a problem hiding this comment.
LGTM — Clean, correct fix for a real bug. The logic properly handles the constraint intersection by comparing bounds and selecting the more restrictive one. Tests are comprehensive and cover the key scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When both minimum and exclusiveMinimum exist (e.g., from .int().positive()), the conversion now picks the more restrictive constraint. Previously, the inclusive minimum would overwrite the exclusive one, producing incorrect output like
minimum: -9007199254740991instead ofminimum: 0.Same fix applied for maximum/exclusiveMaximum.