fix(docs): make the prefault example runnable (declare const schema)#6063
Open
DucMinhNe wants to merge 1 commit into
Open
fix(docs): make the prefault example runnable (declare const schema)#6063DucMinhNe wants to merge 1 commit into
const schema)#6063DucMinhNe wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — docs-only fix adding the missing const schema = binding to the prefault code example so it's self-contained and runnable.
- Add
const schema =to prefault docs example — the dangling expressionz.string().transform(…).prefault("tuna")followed byschema.parse(undefined)would throw aReferenceErroron copy-paste. Bindingconst schema =makes the example consistent with every parallel example in the Defaults/Prefaults/Catch sections.
DeepSeek Pro (free via Pullfrog for OSS) | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The second example in the Prefaults section of
api.mdxis not runnable:The first line is a dangling expression —
schemais never declared — and the second line then callsschema.parse(...)on an undefined binding. Copy-pasting this throws aReferenceError(or, if aschemafrom a previous block is in scope, silently uses that one, which returns0, contradicting the// => 4comment).Every parallel example in the surrounding Defaults/Prefaults/Catch sections binds
const schema = ...— including thedefault(0)example directly above this one.Change
Prepend
const schema =so the example is self-contained and correct:Now
prefaultfeeds"tuna"through thestring → lengthtransform, yielding4as the comment states. Docs-only change.