Skip to content

Conversation

@JoshuaBehrens
Copy link
Contributor

Follow up to #12388 . It ensures, that the new and unreleased property name can only be used for the list representation to prevent ambiguous configurations.

grafik

@Seldaek @dzuelke I do not know if I am thinking to simple about it, but when the schema does not even allow it, it cannot go wrong anywhere. Neither IDE nor composer would work with it. And as it is about a new property, that is not yet released, we can introduce new rules around it.

@dzuelke
Copy link
Contributor

dzuelke commented Nov 3, 2025

I think that's reasonable, @JoshuaBehrens, but I'll let @Seldaek confirm :) Thank you so much for the quick follow-up!

One thing, though: if I understand all the test changes from #12388 correctly, you changed a bunch of the example fixtures that use the object/assoc repositories notation to the new name notation, and I think it would be a good idea to bring those back, since AFAICT the object notation is currently untested for the regular "load a config" command.

There are a bunch of tests for the object/assoc notation for JsonManipulator etc. already, I think it's really just JsonConfigSourceTest.php‎ that is currently lacking this little bit of coverage by having one or two cases.

But the PR diffs are fairly large and I have lost my train of thought a few times trying to figure out if I am just missing the fact that it's already there, so please forgive me if it's an oversight on my part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants