fix: improve HAProxy PROXY protocol handling#40089
Open
fdurand wants to merge 1 commit into
Open
Conversation
fdurand
commented
Apr 30, 2026
- Defer cowrie.session.connect to dataReceived() so HAProxyWrappingFactory has time to parse the PROXY header and update getPeer() with the real client IP.
- Update sshRegex in output.py to match transport names with wrapper annotations (e.g. "HoneyPotSSHTransport (HAProxyProtocolWrapper),42,x").
- Remove duplicate self.transport.connectionLost() call that was incorrectly triggering a second connection-lost event.
- Defer cowrie.session.connect to dataReceived() so HAProxyWrappingFactory
has time to parse the PROXY header and update getPeer() with the real
client IP.
- Update sshRegex in output.py to match transport names with wrapper
annotations (e.g. "HoneyPotSSHTransport (HAProxyProtocolWrapper),42,x").
- Remove duplicate self.transport.connectionLost() call that was
incorrectly triggering a second connection-lost event.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Member
|
Hi! I'm a bit confused about this one, where's HAProxy being used? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.