Fix four IN subdivision names: TS, UK, PY, DH#957
Open
sachinkr7368 wants to merge 1 commit into
Open
Conversation
Member
|
Thanks for the PR! |
Four Indian subdivisions had a top-level `name:` value that diverged
from the canonical ISO 3166-2 English short name and / or from the
gem's own `translations.en` entry. Aligning all four:
* IN-TS Telangana — `name` was Hindi (तेलंगाना); translations.en already
carried "Telangana".
* IN-UK Uttarakhand — `name` was Hindi (उत्तराखण्ड); translations.en
already carried "Uttarakhand".
* IN-PY Puducherry — `name` was the pre-2006 form "Pondicherry" while
translations.en already carried the post-rename "Puducherry". The
historical name is preserved under `unofficial_names`.
* IN-DH Dadra and Nagar Haveli and Daman and Diu — `name` and
translations.en used the macron transliteration ("Dādra…Damān…")
inconsistent with the ISO 3166-2 OBP English short name, which is
ASCII. Other locale translations (ar, as, hi, etc.) are unchanged.
27f09c0 to
32301e5
Compare
Author
|
@pmor please review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #956.
What
Aligns the top-level
name:field for four Indian subdivisions inlib/countries/data/subdivisions/IN.yaml:Why
name:; these two had Hindi. Hindi forms already live undertranslations.hiand are unchanged.translations.en: Puducherry. The pre-rename label is kept underunofficial_namesso consumers depending on it still get a hit.translations.Verification
YAML still parses; all 36 IN subdivisions load.