Skip to content

[feat][backend] add workspace-level max span limit config#541

Merged
SharkeyChen merged 1 commit into
mainfrom
feat/search-trace-tree-max-span-limit
Jun 4, 2026
Merged

[feat][backend] add workspace-level max span limit config#541
SharkeyChen merged 1 commit into
mainfrom
feat/search-trace-tree-max-span-limit

Conversation

@SharkeyChen

Copy link
Copy Markdown
Collaborator

…archTraceTree

Add configurable max span limit per workspace for the SearchTraceTree API. Workspaces not in the config will fallback to 10000 spans.

What type of PR is this?

Check the PR title

  • This PR title match the format: [<type>][<scope>] <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese

(Optional) More detailed description for this PR(en: English/zh: Chinese)

en:
zh(optional):

(Optional) Which issue(s) this PR fixes

@SharkeyChen SharkeyChen force-pushed the feat/search-trace-tree-max-span-limit branch 2 times, most recently from da01c5f to 9cdfa23 Compare June 4, 2026 08:43
@codecov

codecov Bot commented Jun 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #541      +/-   ##
==========================================
+ Coverage   77.41%   77.42%   +0.01%     
==========================================
  Files         662      662              
  Lines       74864    74875      +11     
==========================================
+ Hits        57956    57974      +18     
+ Misses      13487    13483       -4     
+ Partials     3421     3418       -3     
Flag Coverage Δ
unittests 77.42% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
backend/modules/observability/application/trace.go 78.16% <100.00%> (+0.01%) ⬆️
...es/observability/domain/component/config/config.go 53.84% <ø> (+11.53%) ⬆️
...bservability/domain/trace/service/trace_service.go 89.11% <100.00%> (+<0.01%) ⬆️
...ackend/modules/observability/infra/config/trace.go 65.38% <100.00%> (+2.11%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8b2a6f...55b3d4f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…archTraceTree

Add configurable max span limit per workspace for the SearchTraceTree API.
Workspaces not in the config will fallback to 10000 spans.
@SharkeyChen SharkeyChen force-pushed the feat/search-trace-tree-max-span-limit branch from 9cdfa23 to 55b3d4f Compare June 4, 2026 09:32
@SharkeyChen SharkeyChen merged commit 7a0c61c into main Jun 4, 2026
16 checks passed
@SharkeyChen SharkeyChen deleted the feat/search-trace-tree-max-span-limit branch June 4, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants