Skip to content

Fix Gitlab Milestone, Author field type#324

Open
PhompAng wants to merge 3 commits into
danger:masterfrom
PhompAng:gitlab-milestone
Open

Fix Gitlab Milestone, Author field type#324
PhompAng wants to merge 3 commits into
danger:masterfrom
PhompAng:gitlab-milestone

Conversation

@PhompAng

Copy link
Copy Markdown

Gitlab Milestone

Refer to #322

  • Gitlab Milestone due_date and start_date only send a date.
image image

Gitlab Author

  • Author email can be null if the user doesn't set a public email address.

@f-meloni f-meloni left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to add a unit test for this case

@Vacxe

Vacxe commented Feb 12, 2026

Copy link
Copy Markdown
Member

Have you tried to use default ISO8601 serializer?

Example

...
@Serializable(with = LocalDateIso8601Serializer::class) 
@SerialName("due_date")
val dueDate: LocalDate? = null
....

@PhompAng

Copy link
Copy Markdown
Author

Thank you for the comment. I've updated the unit test and use the default serializer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants