Use bulk writes instead of per-element writes in vector serialization#681
Open
r-devulap wants to merge 1 commit into
Open
Use bulk writes instead of per-element writes in vector serialization#681r-devulap wants to merge 1 commit into
r-devulap wants to merge 1 commit into
Conversation
Replace inefficient element-by-element write loops with bulk write operations in MemorySegmentVectorProvider: - writeFloatVector: Extract underlying float array and use writeFloats() instead of looping with writeFloat() - writeByteSequence: Extract underlying byte array and use write() instead of looping with writeByte()
Contributor
|
Before you submit for review:
If you did not complete any of these, then please explain below. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace inefficient element-by-element write loops with bulk write operations in MemorySegmentVectorProvider:
With highway as the SIMD backend #668 , the scalar writes show up as a bottleneck when constructing index on a AWS instance x8i.24xlarge (2-socket 96 core Intel GNR) .