[Spark] Add unsafeVolatileTableId to SnapshotDescriptor and migrate callsites#7016
Open
huan233usc wants to merge 1 commit into
Open
Conversation
… from deltaLog.unsafeVolatileTableId
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Adds
unsafeVolatileTableIdto theSnapshotDescriptortrait, defaulting tometadata.id.Snapshotoverrides it to return theDeltaLog's volatile cached table id: the logging helpers onSnapshotare invoked during state reconstruction itself, and readingmetadata.idthere would re-enter the reconstruction lazy val on the same thread and overflow the stack, so the always-available cached id is used instead.Call sites that previously reached through
snapshot.deltaLog.unsafeVolatileTableId(row tracking materialized column name resolution, streaming schema tracking log creation, and theSnapshotlogging helpers) now usesnapshot.unsafeVolatileTableIddirectly, reducing directDeltaLogdependencies on the snapshot read path.How was this patch tested?
Existing unit tests. This is a refactor with no behavior change.
Does this PR introduce any user-facing changes?
No