fix(upload): replace predictable uniqid() with cryptographically secure random_bytes()#754
Merged
Conversation
…re random_bytes() it doesnt really matter for security, but its a bad practice
Owner
|
Please understand, the app is supposed to be full of bad coding and vulnerabilities, we don't need fixes for things like this. |
Contributor
Author
|
i understand the app needs to be vulnerable, but this pr only changes the impossible difficulty which should show actual secure code, same as #752 which was merged yesterday. its gonna show people that learn on dvwa bad practices |
Owner
|
ok, but for future ones, remember that we aren't supposed to be perfect, it is designed to have issues for people to find. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
uniqid()is based on the system microtime and is inherently predictable. i changed it torandom_bytes(), because even if it doesn't change the security, it's still a bad practicewhat changed
md5( uniqid() . $uploaded_name ): replaced withbin2hex( random_bytes( 16 ) )$target_fileand$temp_file$random_namevariable