[1548] FIX: Unload environment on delete#1562
Open
jgfranco17 wants to merge 5 commits into
Open
Conversation
|
Hi! I wrote a fix for this before seeing the issue + this PR. Yours looks a bit simpler in terms of the actual implementation, but you might want to take my code for the tests, as yours has a chance of leaving the working tree dirty if it fails. |
Author
Hi @winterqt, thanks for the assist! I've updated the test scripts accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: unload environment when
.envrcis deletedAddresses #1548.
When a loaded
.envrcis deleted, direnv fails to unload the environment on the next prompt eval (or oncdout of the directory).Root cause: In
cmd_export.go, the early-return guard was:Meanwhile
DIRENV_DIFFis still set in the shell from the previous load, so the exported variables remain in the environment indefinitely.Changes
DIRENV_DIFFto be unsetTesting
.envrc