Conversation
shw700
reviewed
Jun 11, 2026
| proxies (Dict[str, str]): HTTP proxies to use. Mapping of protocol to URL. | ||
| insecure (bool): Skip https validation. | ||
| verify (str): Either a boolean, in which case it controls whether we verify the server’s TLS certificate, or a string, in which case it must be a path to a CA bundle to use. | ||
| timeout (float or tuple): Seconds to wait for the server before raising an error. Use a (connect_timeout, read_timeout) tuple to set them independently. None means no timeout. |
Collaborator
There was a problem hiding this comment.
Might want to be a little bit more precise because this sounds like a generic read timeout but AFAIK it's not; it's the time-to-first-read timeout.
So maybe, "Seconds to wait for server connect/initial read before raising an error."
shw700
reviewed
Jun 11, 2026
| swclient: str = DEFAULT_SWCLIENT, version: str = DEFAULT_VERSION, | ||
| proxies: Dict[str, str] = None, insecure: bool = False, verify: Union[str, bool, None] = None): | ||
| proxies: Dict[str, str] = None, insecure: bool = False, verify: Union[str, bool, None] = None, | ||
| timeout: Union[float, tuple, None] = None): |
Collaborator
There was a problem hiding this comment.
How about tuple[float, float] for maximum precision?
Collaborator
Author
There was a problem hiding this comment.
make sense, done updating the typehint
shw700
approved these changes
Jun 15, 2026
shw700
requested changes
Jun 16, 2026
shw700
left a comment
Collaborator
There was a problem hiding this comment.
Please change target branch to next
shw700
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: