fix(devcontainer): expose UI/API ports for host access#405
Open
faisu wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes host access to the Dograh UI and API in the devcontainer. Services bind correctly inside the container, but
localhost:3000/:8000on the Mac were unreachable without manual port forwarding.Fixes #404
Changes
3000and8000on theworkspaceservice in.devcontainer/docker-compose.ymlWhy
Setup docs tell contributors to open
http://localhost:3000, butdevcontainer.jsononly auto-forwards infra ports and setsonAutoForward: ignorefor 3000/8000. See #1234.Test plan
bash scripts/start_services_dev.shsucceeds (migrations + API up)cd ui && npm run dev -- --hostname 0.0.0.0curl http://localhost:8000/api/v1/healthreturns OKhttp://localhost:3000loads