Pin variables used in match (for elixir 1.20)#143
Open
geekingfrog wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates lib/websockex/frame.ex to use the pin operator (^) when matching binary sizes with the size and len variables. This ensures correct pattern matching behavior and compatibility with newer Elixir versions. There are no review comments, so I have no feedback to provide.
Elixir 1.20 is getting stricter regarding matching when a variable is used. This changes remove a bunch of warnings of the form: ``` the variable "len" is accessed inside size(...) of a bitstring but it was defined outside of the match. You must precede it with the pin operator ``` See https://github.com/elixir-lang/elixir/blob/v1.20/CHANGELOG.md#elixir-12 for the changelog
Author
|
Note, it's the same as #142 but also fix the warnings in the test files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Elixir 1.20 is getting stricter regarding matching when a variable is used.
This changes remove a bunch of warnings of the form:
See https://github.com/elixir-lang/elixir/blob/v1.20/CHANGELOG.md#elixir-12 for the changelog