Skip to content

lintcmd/cache: implement GOCACHEPROG#1704

Closed
bradfitz wants to merge 1 commit into
dominikh:masterfrom
bradfitz:bradfitz/staticcheck
Closed

lintcmd/cache: implement GOCACHEPROG#1704
bradfitz wants to merge 1 commit into
dominikh:masterfrom
bradfitz:bradfitz/staticcheck

Conversation

@bradfitz

@bradfitz bradfitz commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

Fixes #1458

Fixes dominikh#1458

Signed-off-by: Brad Fitzpatrick <bradfitz@golang.org>
@bradfitz

bradfitz commented Mar 6, 2026

Copy link
Copy Markdown
Contributor Author

Let me know what, if anything, you want in terms of integration tests. I wasn't sure whether you'd want to pull in a dep on, say, https://github.com/bradfitz/go-tool-cache and its cmd/gocached and client program.

@bradfitz

bradfitz commented Mar 6, 2026

Copy link
Copy Markdown
Contributor Author

Also, if you want this broken up into smaller chunks, I'm happy to do that.

e.g. I could send out just the Cache interface and renames to DiskCache first, without adding the GOCACHEPROG stuff.

But first I wanted to send it all (it's tolerably sized, IMO) and see if you had any high level thoughts before I revised it for review.

@bradfitz

Copy link
Copy Markdown
Contributor Author

Some results from Tailscale deploying this change in our CI on March 9th...

image

@bradfitz

bradfitz commented Apr 9, 2026

Copy link
Copy Markdown
Contributor Author

@dominikh, can you take a look?

@dominikh

dominikh commented Apr 9, 2026

Copy link
Copy Markdown
Owner

Applied as ba2c208. As for integration tests, that'll be my users (you) for now.

@dominikh dominikh closed this Apr 9, 2026
@bradfitz

Copy link
Copy Markdown
Contributor Author

Thanks! Would you like integration tests? If so, how much are you okay with dependency-wise? Would you be okay depending on https://github.com/bradfitz/go-tool-cache for a test server, or prefer a copy?

@dominikh

Copy link
Copy Markdown
Owner

I wouldn't mind some tests, and a dependency would be fine 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GOCACHEPROG or otherwise hookable caching support

2 participants