In run-first.sh tells the user to not set 0.0.0.0 as LISTEN_IP#1113
Open
feroda wants to merge 1 commit into
Open
In run-first.sh tells the user to not set 0.0.0.0 as LISTEN_IP#1113feroda wants to merge 1 commit into
feroda wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I have experimented weird behaviour with my brand new setup of edumeet.
This was due to set LISTEN_IP to 0.0.0.0 that cannot be used.
So i adapted run-first.sh script to avoid setting that value. I did not check for errors if user still insert it, but I see that there are not too many checks on value inserted. I add the plus that if the LISTEN_IP is not specified, it will be equal to EXTERNAL_IP
I hope it could be useful for others.
Thanks for your work that after 5 years is flying high!