Open
Conversation
satur9nine
commented
Jan 17, 2026
- Explicit .thumb/.thumb_func ensures the code is assembled and tagged as Thumb. Cortex‑M7 has no ARM state; without this you can get assembler errors or a HardFault if a call lands on an address without the Thumb bit set.
- .syntax unified and the corrected .type syntax improve compatibility with modern assemblers (GAS/clang‑as) that may reject the original #function form
- ldmia ..., pc is replaced with an explicit bx lr, which is the safer/clearer return sequence in Thumb and avoids any assembler restrictions around loading pc from a non‑SP base register.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.