fix: accept JWKS responses with +json content types#1
Merged
Conversation
f659eba to
a6f7f5e
Compare
a6f7f5e to
fcdb4b1
Compare
Coverage Report for CI Build 5Warning No base build found for commit Coverage: 92.123%Details
Uncovered Changes
Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
ieQu1
approved these changes
Apr 17, 2026
thalesmg
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
application/*+jsonresponse content types when decoding HTTP JSON payloadsapplication/jwk-set+json; charset=utf-8application/jsonandapplication/jwthandling intactVerification
escript /mnt/data/emqx/gwt/260416-sso-support-more-content-type/rebar3 eunit --module=oidcc_provider_configuration_worker_testin/mnt/data/emqx/oidccescript ../../rebar3 eunit --module=oidcc_provider_configuration_worker_testindeps/oidccfrom the EMQX checkoutenv PROFILE=emqx-enterprise SUITES=apps/emqx_dashboard_sso/test/emqx_dashboard_sso_oidc_SUITE.erl CASES=t_jwks_content_type_suffix make apps/emqx_dashboard_sso-ctin the EMQX checkoutNotes
application/jwk-set+json; charset=utf-8JWKS failure reported in EMQX 6.1.0 Docker OIDC SSO Login Fails with provider_not_ready emqx#16834.apps/emqx_dashboard_ssoCT run in EMQX was attempted, but the run was blocked by unrelated environment failures in other suites (quicer/libcrypto.so.1.1and subsequent dirty suite state), so the focused regression coverage above is the relevant verification for this change.