Skip to content

Jvm tuning based on issue #91#92

Merged
shroffk merged 3 commits into
mainfrom
JVM_tuning
Jun 11, 2026
Merged

Jvm tuning based on issue #91#92
shroffk merged 3 commits into
mainfrom
JVM_tuning

Conversation

@shroffk

@shroffk shroffk commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Adding jvm options for Phoebus and AA
#91

@shroffk shroffk requested review from jacomago and ralphlange June 11, 2026 15:22
@shroffk

shroffk commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

@mdavidsaver can't seem to add you as a reviewer

@shroffk shroffk marked this pull request as ready for review June 11, 2026 15:25
@mdavidsaver

Copy link
Copy Markdown

I do know enough to comment on the ansible-ness of this change, but it looks like the right idea.

@ralphlange

Copy link
Copy Markdown
Contributor

Well, #91 was asking for a default setting that applies to all JVMs inside the Training-VM.
This PR implements two specific ones.
Is there a non-confusing way to have generic settings and per-role overrides?

Also, I would prefer the variable names being consistent.

@jacomago

Copy link
Copy Markdown

You

Well, #91 was asking for a default setting that applies to all JVMs inside the Training-VM. This PR implements two specific ones. Is there a non-confusing way to have generic settings and per-role overrides?

Also, I would prefer the variable names being consistent.

Could do a java role, but I think there should be quite different settings for ui vs services, so in context of that I think this is fine.

@ralphlange

Copy link
Copy Markdown
Contributor

Well, #91 was asking for a default setting that applies to all JVMs inside the Training-VM. This PR implements two specific ones. Is there a non-confusing way to have generic settings and per-role overrides?

Could do a java role, but I think there should be quite different settings for ui vs services, so in context of that I think this is fine.

I can see ui vs. services, but if all services have similar requirements, there could still be a default one that phoebus overrides.

@ralphlange

Copy link
Copy Markdown
Contributor

Could do a java role, but I think there should be quite different settings for ui vs services, so in context of that I think this is fine.

Actually, looking at this PR, they are not really "quite different", are they?
(Maybe I don't understand them well enough.)

@shroffk

shroffk commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

While in this PR they are not different but, as mentioned by sky, there is good reason for them to be separate.

@ralphlange

Copy link
Copy Markdown
Contributor

Which, again, I understand and support.

@shroffk

shroffk commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

should we merge and close issue #91 :)

@ralphlange

Copy link
Copy Markdown
Contributor

After streamlining the names, please.

@ralphlange ralphlange left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable names should be consistent.

@shroffk

shroffk commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

Done, using the same that was in archiver appliance

@ralphlange ralphlange left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@shroffk shroffk merged commit e385f05 into main Jun 11, 2026
14 checks passed
@shroffk shroffk deleted the JVM_tuning branch June 11, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants