Jvm tuning based on issue #91#92
Conversation
|
@mdavidsaver can't seem to add you as a reviewer |
|
I do know enough to comment on the ansible-ness of this change, but it looks like the right idea. |
|
Well, #91 was asking for a default setting that applies to all JVMs inside the Training-VM. Also, I would prefer the variable names being consistent. |
|
You
Could do a java role, but I think there should be quite different settings for ui vs services, so in context of that I think this is fine. |
I can see ui vs. services, but if all services have similar requirements, there could still be a default one that phoebus overrides. |
Actually, looking at this PR, they are not really "quite different", are they? |
|
While in this PR they are not different but, as mentioned by sky, there is good reason for them to be separate. |
|
Which, again, I understand and support. |
|
should we merge and close issue #91 :) |
|
After streamlining the names, please. |
ralphlange
left a comment
There was a problem hiding this comment.
The variable names should be consistent.
|
Done, using the same that was in archiver appliance |
Adding jvm options for Phoebus and AA
#91